[U-Boot] [PATCH 06/11] at91: Add defines for spi SoC access
Reinhard Meyer
u-boot at emk-elektronik.de
Mon Nov 1 13:31:38 CET 2010
Dear Wolfgang Denk,
> Dear Reinhard Meyer,
>
> In message<4CCE7DCD.6090004 at emk-elektronik.de> you wrote:
>>
>> If we touch header and driver anyway, we could get rid of the depreciated typedefs,
>> to get conform to the coding style.
>
> I recommend NOT doing this, at least not as part of this patch series.
>
> If a clean-up is intended, it should be done in a strictly separate set
> of patches (either before or after the current series).
In this particular case the driver is not yet using the (existing) struct
at91_spi at all....
WAIT....!!!
There is the COMMON driver atmel_spi.c with atmel_spi.h in drivers/spi.
There need not be and should not be an at91_spi.h; or do I miss
something here?
Best Regards,
Reinhard
More information about the U-Boot
mailing list