[U-Boot] [PATCH 4/4] UBI/UBIFS: Prevent UBI partition change while UBIFS is mounted

[Ben Gardiner]

On Tue, Nov 2, 2010 at 6:49 AM, Stefan Roese <sr at denx.de> wrote:
> Hi Wolfgang,
>
> On Monday 01 November 2010 20:06:31 Wolfgang Denk wrote:
>> > > I'm a bit biased here - from standard Unix command usage it seems
>> > > natural that you have to manually umount first, but then we have very
>> > > smple device handling in U-Boot, with always only one device in
>> > > access.  Would it not make sense to auto-unmount in case the user
>> > > switches the device?
>> >
>> > I can implement it this way if preferred. I'll prepare a new for this
>> > later.
>>
>> As mentioned - I am not sure what would be best here.
>>
>> What is your own position?
>
> I prefer the first approach, not automatically unmounting upon UBI device
> change. One plus for this version is that the user might have issued the 2nd
> "ubi part" by mistake and didn't really want to unmount the UBIFS filesystem
> in the first place.
>
> But I have no strong feeling here. So I'm open to suggestions from others
> which version is the preferred one.

FWIW: I prefer the option where the UBIFS is automatically unmounted.
At first I was in favour of not automatically unmounting since it
emulates more closely the interface of a unix environment, to which I
am biased. However, automatically unmounting has an important
advantage: the state resulting from a 'ubi part' command is the same
regardless of the initial 'mounted state'. This make scripting boot
sequences simpler. The alternative would be to provide a 'test
mounted' command along with the option where ubi part does not
automatically unmount.

Best Regards,
Ben Gardiner

---
Nanometrics Inc.
http://www.nanometrics.ca