[U-Boot] [PATCH] common/cmd_bdinfo.c: fix do_bdinfo() for AVR32

Reinhard Meyer u-boot at emk-elektronik.de
Tue Nov 2 17:34:36 CET 2010


Dear Andreas Bießmann,

Your e-Mail is:
Content-Transfer-Encoding: quoted-printable

That means ' ' comes as =20, '=' comes as =3D

> There was a prototype change from do_bdinfo(.. char *) to do_bdinfo(.. char *
> const). This patch respect this change for AVR32 architecture.
> 
> Signed-off-by: Andreas Bießmann <biessmann at corscience.de>
> ---
>  common/cmd_bdinfo.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
> index bba7374..1d76ffa 100644
> --- a/common/cmd_bdinfo.c
> +++ b/common/cmd_bdinfo.c
> @@ -304,7 +304,7 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  
>  #elif defined(CONFIG_AVR32)
>  
> -int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
> +int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  {
>  	bd_t *bd = gd->bd;
>  

I see that cmd_bdinfo.c has lots of coding style violations, but
some architectures have them fixed.
Could we at least fix them in the AVR32 part, if we touch it anyway?
See the BLACKFIN example ;)

Or is it OK to leave it as is? Wolfgang?

Best Regards,
Reinhard


More information about the U-Boot mailing list