[U-Boot] [PATCH v2 1/2] arm920t/at91/reset.c: fix weak reset_board()

Joakim Tjernlund joakim.tjernlund at transmode.se
Thu Nov 4 02:00:28 CET 2010


>
> The arm920t compiler/linker dif not handle weak functions correctely.
> Therefore the linker tried to link outside the ELF (isn't that lazy
> linking?). This leads to segfault of linker in the end.
>
> This patch adds a empty stub for weak function reset_board() to catch
> that case.

I believe this is the wrong approach.
Instead you should fix the relocation/fixup routine not to relocate
NULL ptrs. NULL ptrs are absolute values and should be left as is.

See http://git.denx.de/?p=u-boot.git;a=commit;h=d1e0b10accdbac2e0a8b2cbf7c589645442f87c5
for a fix to ppc that went in recently

 Jocke



More information about the U-Boot mailing list