[U-Boot] [PATCH] ARMV7: OMAP3: BeagleBoard: add xM rev B to ID table

[Nishanth Menon]

Jason Kridner wrote, on 11/05/2010 01:46 AM:
> From: Koen Kooi<koen at dominion.thruhere.net>
>
> Patch was updated by Jason Kridner<jkridner at beagleboard.org>:
> * Use tabs to match style of other board revisions
> * Only include board revisions that exist
> * Default to the same configuration as the latest revision, but
>    without setting 'beaglerev'
>
> Signed-off-by: Jason Kridner<jkridner at beagleboard.org>
not signed-off-by: Koen?

> ---
>   board/ti/beagle/beagle.c |   20 +++++++++++++++++++-
>   board/ti/beagle/beagle.h |    3 ++-
>   2 files changed, 21 insertions(+), 2 deletions(-)
>
> diff --git a/board/ti/beagle/beagle.c b/board/ti/beagle/beagle.c
> index 520e57d..93c452e 100644
> --- a/board/ti/beagle/beagle.c
> +++ b/board/ti/beagle/beagle.c
> @@ -176,7 +176,7 @@ int misc_init_r(void)
>   					TWL4030_PM_RECEIVER_VAUX2_DEV_GRP,
>   					TWL4030_PM_RECEIVER_DEV_GRP_P1);
>   		break;
> -	case REVISION_XM:
> +	case REVISION_XM_A:
>   		printf("Beagle xM Rev A\n");
>   		setenv("beaglerev", "xMA");
>   		setenv("mpurate", "1000");
> @@ -187,8 +187,26 @@ int misc_init_r(void)
>   					TWL4030_PM_RECEIVER_VAUX2_DEV_GRP,
>   					TWL4030_PM_RECEIVER_DEV_GRP_P1);
>   		break;
> +	case REVISION_XM_B:
> +		printf("Beagle xM Rev B\n");
> +		setenv("beaglerev", "xMB");
> +		setenv("mpurate", "1000");
> +		MUX_BEAGLE_XM();
> +		/* Set VAUX2 to 1.8V for EHCI PHY */
> +		twl4030_pmrecv_vsel_cfg(TWL4030_PM_RECEIVER_VAUX2_DEDICATED,
> +					TWL4030_PM_RECEIVER_VAUX2_VSEL_18,
> +					TWL4030_PM_RECEIVER_VAUX2_DEV_GRP,
> +					TWL4030_PM_RECEIVER_DEV_GRP_P1);
> +		break;
>   	default:
>   		printf("Beagle unknown 0x%02x\n", get_board_revision());
> +		setenv("mpurate", "1000");

It looks to me looking at the file that mpurate usage is CPU based and 
NOT board based.. maybe you should use the cpu idendity to decide on 
mpurate instead?


> +		MUX_BEAGLE_XM();
> +		/* Set VAUX2 to 1.8V for EHCI PHY */
> +		twl4030_pmrecv_vsel_cfg(TWL4030_PM_RECEIVER_VAUX2_DEDICATED,
> +					TWL4030_PM_RECEIVER_VAUX2_VSEL_18,
> +					TWL4030_PM_RECEIVER_VAUX2_DEV_GRP,
> +					TWL4030_PM_RECEIVER_DEV_GRP_P1);
>   	}
>
>   	switch (get_expansion_id()) {
> diff --git a/board/ti/beagle/beagle.h b/board/ti/beagle/beagle.h
> index 7d8dee0..fa893c4 100644
> --- a/board/ti/beagle/beagle.h
> +++ b/board/ti/beagle/beagle.h
> @@ -37,7 +37,8 @@ const omap3_sysinfo sysinfo = {
>   #define REVISION_AXBX	0x7
>   #define REVISION_CX	0x6
>   #define REVISION_C4	0x5
> -#define REVISION_XM	0x0
> +#define REVISION_XM_A	0x0
> +#define REVISION_XM_B	0x1
>
>   /*
>    * IEN  - Input Enable


-- 
Regards,
Nishanth Menon