[U-Boot] [PATCH] Switch from library archives to partial linking

Andreas Bießmann andreas.devel at googlemail.com
Sun Nov 7 17:54:26 CET 2010


Dear Sebastien Carlier,

Am 07.11.2010 um 17:18 schrieb Sebastien Carlier:

> Dear Andreas,
> 
> On 11/07/2010 04:30 PM, Andreas Bießmann wrote:
>> I guess the boards are broken before your library changes too.
> 
> The boards in question do actually build with library archives.  The
> final binary does not make use of the NFS stuff, therefore the linker
> does not need to resolve the undefined symbols in it.

I see .. so I guess the build system for net should be fixed.

>> But two points regarding your described approach.
>> - The respective boards need a fix, if they do (conditionally)
>> disable CMD_NET and miss CMD_NFS it is their fault and the respective
>> boards config should be fixed
> 
> The boards unconditionally disable CMD_NET and miss CMD_NFS.  Although
> this is not a meaningful configuration, it used to build...

Indeed this configuration makes no sense but the information "let NFS stuff out" is implicit, isn't it?
To get your new linking fixed to work with this configuration you could introduce a new 'check service' to fixup those situations. But I think this should be fixed in the makefiles for net. And with that point of view those changes could go into the same patch which does the new linking. Cause you do not fixup boards to get them built but you make your linking more robust.

>> - The build for net commands need a fix if they will build NFS stuff
>> without NET stuff
> 
> It is possible for net/Makefile to disable all modules if CMD_NET is
> disabled.  

In my eyes this is the better way to go for your concrete issue, but please let some others comment. I'm a fairly new contributor to u-boot and do not know about those questions. This is only my point of view.

regards

Andreas Bießmann


More information about the U-Boot mailing list