[U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

[Wolfgang Denk]

Dear Haiying Wang,

In message <1288970062.1855.44.camel at haiying-laptop> you wrote:
> 
> Wolfgang's latest commit to change all TEXT_BASE to CONFIG_SYS_TEXT_BASE
> breaks the build for nand_spl. He defined CONFIG_SYS_TEXT_BASE in board

Which board(s) / configuration(s) are you talkign about?

> header file for CONFIG_NAND, and renamed TEXT_BASE to
> CONFIG_SYS_TEXT_BASE in nand_spl/board/.../Makefile. Then for
> u-boot-spl, the CONFIG_SYS_TEXT_BASE is always the value defined in
> header file, which is, for example, 0xf8f82000 for MPC8536/8569/p1_p2/,
> not the one defined in nand-spl's Makefile, which is 0xfff00000. Thus it

It is fundamentally broken to define such settings in a Makefile. They
do not belong there, an never did.

If you take for example the MPC8536DS_NAND configuration, this defines
CONFIG_NAND as indication for the NAND booting config option, so it
should be trivial to add some

	#ifdef CONFIG_NAND
	#define CONFIG_SYS_TEXT_BASE ...
	#else
	#define CONFIG_SYS_TEXT_BASE ...
	#endif

to the respective board config file(s).

> Can you take a look at it? Defining CONFIG_SYS_TEXT_BASE in header file
> does impact the TEXT_BASE defined in Makefile for nand_spl.

Please remove any such defines from Makefiles.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
All this doesn't alter anything, you know. The world is still full of
stupid people. They don't use their brains. They don't seem  to  want
to think straight.                    - Terry Pratchett, _Soul Music_