[U-Boot] kirkwood: CONFIG_SYS_INIT_SP_ADDR wrong?

Wolfgang Denk wd at denx.de
Wed Nov 10 21:11:21 CET 2010


Dear Heiko Schocher,

In message <4CDABCF8.901 at denx.de> you wrote:
> 
> Then we should add this alignment into the generation of
> GENERATED_GBL_DATA_SIZE.

No.  GENERATED_GBL_DATA_SIZE is just a size.  As you don't really know
the alignment of the base address that GENERATED_GBL_DATA_SIZE is
added to or substracted from, you cannot add the alignment
requirements here.

This must be done where they are neede d- whichis also much better to
make the code readable / understandable.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He'd been wrong, there _was_ a light at the end of the tunnel, and it
was a flamethrower.                         - Terry Pratchett, _Mort_


More information about the U-Boot mailing list