[U-Boot] [PATCH] mpc83xx: Make it boot again

Kumar Gala galak at kernel.crashing.org
Fri Nov 12 20:26:17 CET 2010


On Nov 12, 2010, at 11:22 AM, Scott Wood wrote:

> On Fri, 12 Nov 2010 09:58:53 -0600
> Kumar Gala <galak at kernel.crashing.org> wrote:
> 
>> 
>> On Nov 4, 2010, at 11:47 AM, Wood Scott-B07421 wrote:
>> 
>>> Joakim Tjernlund wrote:
>>>> Trial and error suggests that map_flash_by_law1 needs
>>>> an isync(padding with 4 nop's also did the trick)
>>>> after updating LBLAWAR1 to make sure the the change has
>>>> reached the HW before continuing with the code that depends on it.
>>>> Add an isync to remap_flash_by_law0 for good measure too.
>>> 
>>> To be totally safe, we probably want to do a readback plus twi (to turn a data dependency into a flow dependency) before the isync.
>> 
>> We only do the 'twi' for loads/in_beX not stores/out_beX.
> 
> Yes, and the readback is a load.

following the store with a load should be sufficient I dont think we need the twi in this case.

- k



More information about the U-Boot mailing list