[U-Boot] [PATCH v2 1/1] imx: Get fec mac address from fuse

[Wolfgang Denk]

Dear Jason Liu,

In message <1289705187-11350-1-git-send-email-r64343 at freescale.com> you wrote:
> The patch is to support getting FEC MAC address from fuse bank.
> 
> Signed-off-by: Jason Liu <r64343 at freescale.com>

Please add the i.MX custodian on Cc:

> diff --git a/arch/arm/include/asm/arch-mx25/imx-regs.h b/arch/arm/include/asm/arch-mx25/imx-regs.h
> index f5a2929..6afcfdf 100644
> --- a/arch/arm/include/asm/arch-mx25/imx-regs.h
> +++ b/arch/arm/include/asm/arch-mx25/imx-regs.h
> @@ -128,12 +128,8 @@ struct iim_regs {
>  	u32 iim_prev;
>  	u32 iim_srev;
>  	u32 iim_prog_p;
> -	u32 res1[0x1f5];
> -	u32 iim_bank_area0[0x20];
> -	u32 res2[0xe0];
> -	u32 iim_bank_area1[0x20];
> -	u32 res3[0xe0];
> -	u32 iim_bank_area2[0x20];
> +	u32 res[0x1f5];
> +	u32 iim_bank_area[0x100 * 3];

Please explain what exactly you are doing here.

> --- a/arch/arm/include/asm/arch-mx27/imx-regs.h
> +++ b/arch/arm/include/asm/arch-mx27/imx-regs.h
> @@ -202,8 +202,7 @@ struct iim_regs {
>  	u32 iim_scs1;
>  	u32 iim_scs2;
>  	u32 iim_scs3;
> -	u32 res[0x1F0];
> -	u32 iim_bank_area0[0x100];
> +	u32 iim_bank_area[0x100 * 2];

... and here.

What makes me suspicious is that you are changing the size of these
structs here - from 4224 to 5120 for i.MX25, and from 3068 to 2108 for
i.MX27.

Here it becomes more, there it becomes less?

Is this correct?

> diff --git a/arch/arm/include/asm/arch-mx5/imx-regs.h b/arch/arm/include/asm/arch-mx5/imx-regs.h
> index 0b6249a..93eef48 100644
> --- a/arch/arm/include/asm/arch-mx5/imx-regs.h
> +++ b/arch/arm/include/asm/arch-mx5/imx-regs.h
> @@ -205,6 +205,9 @@
>  #define BOARD_REV_1_0           0x0
>  #define BOARD_REV_2_0           0x1
>  
> +#define IMX_IIM_BASE		(IIM_BASE_ADDR)
> +#define IIM_MAC			0x109
> +
>  #if !(defined(__KERNEL_STRICT_NAMES) || defined(__ASSEMBLY__))
>  #include <asm/types.h>
>  
> @@ -275,6 +278,27 @@ struct src {
>  	u32	sisr;
>  	u32	simr;
>  };
> +
> +struct iim_regs {
> +	u32 stat;
> +	u32 statm;
> +	u32 err;
> +	u32 emask;
> +	u32 fctl;
> +	u32 ua;
> +	u32 la;
> +	u32 sdat;
> +	u32 prev;
> +	u32 srev;
> +	u32 preg_p;
> +	u32 scs0;
> +	u32 scs1;
> +	u32 scs2;
> +	u32 scs3;
> +	u32 res[0x1f1];
> +	u32 iim_bank_area[0x100 * 4];
> +};

And here we have 6144. Is this correct?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Never put off until tomorrow what you can put off indefinitely.