[U-Boot] [PATCH 2/5] e1000: Restructure and streamline PCI device probing
Wolfgang Denk
wd at denx.de
Mon Nov 15 00:04:59 CET 2010
Dear Kyle Moffett,
In message <1284393146-22142-2-git-send-email-Kyle.D.Moffett at boeing.com> you wrote:
> By allocating the e1000 device structures much earlier, we can easily
> generate better error messages and siginficantly clean things up.
>
> The only user-visable change (aside from reworded error messages) is
> that a detected e1000 device which fails to initialize due to software
> or hardware error will still be allocated a device number.
>
> As one example, consider a system with 2 e1000 PCI devices where the
> first controller has a corrupted EEPROM. Using the old code the
> second controller would be "e1000#0", while with this change it would be
> "e1000#1".
>
> This change should hopefully make such EEPROM errors much more
> straightforward to handle correctly in boot scripts and the like.
>
> It is also necessary for a followup patch which allows SPI programming
> of an e1000 controller's EEPROM even if the checksum is invalid.
>
> Signed-off-by: Kyle Moffett <Kyle.D.Moffett at boeing.com>
> ---
> drivers/net/e1000.c | 105 +++++++++++++++++++++++++++------------------------
> drivers/net/e1000.h | 3 +
> 2 files changed, 59 insertions(+), 49 deletions(-)
This patch does not apply any more. Could you please rebase and
resubmit it?
Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Anything that is worth doing at all is worth doing well.
-- Philip Earl of Chesterfield
More information about the U-Boot
mailing list