[U-Boot] [PATCH V4 1/2] arm926ejs: fix linker file for newer ld support

Reinhard Meyer u-boot at emk-elektronik.de
Mon Nov 15 13:00:57 CET 2010


Dear Albert ARIBAUD,
>>> ATM on mainline master branch only five ARM cpus (arm926ejs, arm1136,
>>> arm1176, armv7 and pxa)  have ELF relocation support. Others still use
>>> GOT relocation (or the older fixed-location scheme maybe), which IIUC
>>> means all boards using these other cpus are broken unless a maintainer
>>> gets patches pulled in to support ELF relocs.
>>>
>>> I therefore propose that V5 of my patch fixes arm926ejs, armv7, arm1136,
>>> arm1176 and pxa only, and leave the ten other ARM cpus untouched. Board
>>> maintainers who want to fix their board support for ELF relocs may have
>>> to also fix their cpu if it is not yet.
>>>
>>> Does everyone agree?
>> I dislike having such a mix of different relocation methods.
>>
>> Let's face it: this discussion has been going on for so long already
>> that every interested party could have adapted their code.  I am
>> afraid if we do not force the change now it will never happen.  And I
>> do not want to carry on such a bifurcation much longer.
> 
> Understood.
> 
>> Do you think you could convert the remaining CPUs to ELF relocation as
>> well?  That would probably provide the best base for any further work.
> 
> I can make the changes for other cpus, but I cannot perform even basic 
> testing beyond making sure it still builds.
> 
> Besides, while I can reasonably provide a V5 patch by this evening for 
> the five cpus which already support ELF, I won't be able to provide 
> fixes for the whole of arch/arm/cpu/* until thursday evening/friday 
> morning. Is that ok?

Would it not be "nice" to take the ARM-universal identical code for
relocate, clear bss and transfer to relocated code out of each
ARM/CPU/*/start.S and move it to ARM/LIB/relocate.S ?

You would not have to duplicate and maintain that code in every
ARM CPU type.

That would also pave the path to the relocation in C which I have started
a while ago.

Best Regards,
Reinhard


More information about the U-Boot mailing list