[U-Boot] [PATCH] don't touch non-existent EHCI regs on MPC837x.

[Wolfgang Denk]

Dear Andre Schwarz,

In message <4CE1572C.6080804 at matrix-vision.de> you wrote:
>
> >>> This doesn't seem quite right, the MPC837x has USB controllers.
> >>>        
> >> yes, it has - and it is working fine.
> >> But USB register range 0x00-0xff is reserved and hangs the CPU.
> >>
> >> With this patch USB is working fine on at least MPC8377.
> >>      
> > Then the commit message should make this clear.  At the moment it is
> > pretty much misleading.
> >    
> 
> I didn't add this #ifdef but extended it to not only match 834x but also 
> 837x.
> 
> All I see is that the ifdef'ed code accesses registers which are 
> explicitely reserved on MPC834x and at least MPC837x.

Yes, I don't think this was objected at all.

> What would be an appropriate commit message from your point of view ?

Well, above you wrote "USB register range 0x00-0xff is reserved and
hangs the CPU" - this probably explains the situation pretty well.
However, the subject "non-existent EHCI regs" suggests to me that
there are no USB registers at all.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Uncertain fortune is thoroughly mastered by the equity of the  calcu-
lation.                                               - Blaise Pascal