[U-Boot] [PATCH 1/1] mx51evk: savenv or env save command does not work

[Wolfgang Denk]

Dear Jason Liu,

In message <AANLkTim4k-PnuFDgWvYj3TY4mtLcz7Uzy1-TO9vExxbS at mail.gmail.com> you wrote:
>
> Agree. But I think the original commit for 128KiB env size has been
> reviewed on the mail list and no one against it.

Nobody claims 100.0% coverage in a review.  Sometimes such things slip
through, some times they are detected.

> So, I keep the same setting. If I change it, some guys main complain
> why it change, it will make it
> incompatible with the original env setting and make the customer env lost.

I doubt that. I think I have seen a fair share of different
environment settings. There are many, many in the 1...2 KiB range.
Very, very few exceed 4 KiB. You have to search really hard to find
one that gets close to 8KiB.

> OK,  do you think we need change all the platform to reflect the 16K
> env size for MMC case?

Define "need". There is no urgent need - it's not a bug, the code is
working, though inefficiently.  It's an optimization thingy.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There is, however, a strange, musty smell in the air that reminds  me
of something...hmm...yes...I've got it...there's a VMS nearby, or I'm
a Blit.          - Larry Wall in Configure from the perl distribution