[U-Boot] [PATCH 1/1] mx51evk: savenv or env save command does not work

Stefano Babic sbabic at denx.de
Wed Nov 17 08:54:00 CET 2010


On 11/17/2010 08:29 AM, Jason Liu wrote:
> Agree. But I think the original commit for 128KiB env size has been
> reviewed on the mail list and no one against it.

This does not mean that we cannot change this value when we find it is
wrong....

And as I said previously, the value had no effect because
CONFIG_ENV_NOWHERE was set.

> So, I keep the same setting. If I change it, some guys main complain
> why it change,

There is not at the moment the possibility to store the environment in
the mainline for the mx51evk, nobody complains about a feature that does
not exist....

> We really don't know what data that customer will store. So leave much
> room for them is
> my first though, But consider the fast boot, what you said make sense.

If someone really needs a so large environment, cand send an e-mail to
this ML explaining his reason and posting a patch. It will be discussed
here.

> OK,  do you think we need change all the platform to reflect the 16K
> env size for MMC case?

Your patch refers to the mx51evk. So change the value according to this
discussion and post your patch again for inclusion in mainline. We will
take into account for other boards when new patches will be submitted.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================


More information about the U-Boot mailing list