[U-Boot] [PATCH v2 1/1] mx51evk: savenv or env save command does not work

[Wolfgang Denk]

Dear Jason Liu,

In message <1289980878-31714-1-git-send-email-r64343 at freescale.com> you wrote:
> fix saveenv or env save command not work on mx51evk board.
> with this patch, we can use savenv or env save to
> store enviroments to mmc card slot 0
> 
> Signed-off-by: Jason Liu <r64343 at freescale.com>
> 
> ---
> Changes for v2:
>   - Change MMC env size to 8KiB for the consideration for quick boot
> ---
>  include/configs/mx51evk.h |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/include/configs/mx51evk.h b/include/configs/mx51evk.h
> index f98438d..b4e5738 100644
> --- a/include/configs/mx51evk.h
> +++ b/include/configs/mx51evk.h
> @@ -216,8 +216,9 @@
>   */
>  #define CONFIG_SYS_NO_FLASH
>  
> -#define CONFIG_ENV_SECT_SIZE    (128 * 1024)
> -#define CONFIG_ENV_SIZE		CONFIG_ENV_SECT_SIZE
> -#define CONFIG_ENV_IS_NOWHERE
> +#define CONFIG_ENV_OFFSET      (6 * 64 * 1024)
> +#define CONFIG_ENV_SIZE        (8 * 1024)
> +#define CONFIG_ENV_IS_IN_MMC
> +#define CONFIG_SYS_MMC_ENV_DEV 0

The suggested env size was 16 KiB.

And I think you should add a comment where the 6 * 64 * 1024 is coming
from and why exactly this values is considered to be a good one.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Open the pod bay doors, HAL."                    - Dave Bowman, 2001