[U-Boot] [PATCH] [v2] powerpc/85xx: introduce 'fdt verify' command

Timur Tabi timur at freescale.com
Wed Nov 17 19:40:50 CET 2010


Wolfgang Denk wrote:
>> >  struct fdt_header *working_fdt;
>> > @@ -436,6 +450,10 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
>> >  	else if (strncmp(argv[1], "re", 2) == 0) {
>> >  		fdt_resize(working_fdt);
>> >  	}
>> > +	/* verify the addresses in the fdt */
>> > +	else if (argv[1][0] == 'v') {
>> > +		fdt_verify_addresses(working_fdt);
>> > +	}
>> >  	else {
> 2x incorrect coding style - the "else" goes on the saame line with the
> '}' and the '{'
> 

Ah, the bottom half of the switch statement uses this style:

}
else if


But the top half uses this style:

} else if

And the top half is correct.

-- 
Timur Tabi
Linux kernel developer at Freescale



More information about the U-Boot mailing list