[U-Boot] [PATCH v3] Seagate FreeAgent DockStar support

[Prafulla Wadaskar]

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de]
> On Behalf Of Eric Cooper
> Sent: Monday, November 22, 2010 7:27 PM
> To: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH v3] Seagate FreeAgent DockStar support
> 
> On Sun, Nov 21, 2010 at 09:37:18PM -0800, Prafulla Wadaskar wrote:
> > > diff --git a/board/Seagate/dockstar/kwbimage.cfg
> > > b/board/Seagate/dockstar/kwbimage.cfg
> > [...]
> > Are the contents for this file exactly same as
> > sheevaplug/kwbimage.cfg?  If yes then you can reuse that file and
> > avoid adding this file here by using configuration in board config
> > file.
> 
> No, they're different (DockStar has 128M of RAM vs. SheevaPlug's 256M.)

Okay

> 
> > > diff --git a/boards.cfg b/boards.cfg
> > > index 08e531e..50e9d1b 100644
> > > --- a/boards.cfg
> > > +++ b/boards.cfg
> > > @@ -376,6 +376,7 @@ guruplug	arm	arm926ejs	-		Marvell
> > > 	kirkwood
> > >  mv88f6281gtw_ge	arm	arm926ejs	-		Marvell		kirkwood
> > >  openrd_base	arm	arm926ejs	-		Marvell		kirkwood
> > >  sheevaplug	arm	arm926ejs	-		Marvell		kirkwood
> > > +dockstar	arm	arm926ejs	-		Seagate		Kirkwood
> >
> > Please check if you have missed to maintain this in order
> 
> I couldn't figure out the intended sort order of the current file.
> The comment at the top (about using a sort command) doesn't seem to
> match the contents at all, and there are already several arm926ejs and
> kirkwood boards in various places.
> 
> I'm happy to move this, but please specify exactly where :-)

Yes I know, it would be good if you can re-order them together (separate patch), or just add your board just above suen3.

Regards..
Prafulla . .