[U-Boot] [PATCHv2] mpc83xx: Make it boot again

Joakim Tjernlund joakim.tjernlund at transmode.se
Tue Nov 23 19:16:01 CET 2010


Could we have an ACK before relese please?

> After the removal of COLD/WARM start flags my mpc8321
> board didn't boot anymore.
> Trial and error suggests that map/remap_flash_by_xxx needs
> to wait after updating LBLAWAR1 to make sure the the change has
> reached the HW before continuing with the code that depends on it.
> Final fix suggested by Scott Wood.
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund at transmode.se>
> ---
>
>  v2: Final adjustmenst based on inpt from Scott Wood.
>  arch/powerpc/cpu/mpc83xx/start.S |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/cpu/mpc83xx/start.S b/arch/powerpc/cpu/mpc83xx/start.S
> index e8b1ebc..5a9b790 100644
> --- a/arch/powerpc/cpu/mpc83xx/start.S
> +++ b/arch/powerpc/cpu/mpc83xx/start.S
> @@ -1191,6 +1191,10 @@ map_flash_by_law1:
>     bne 1b
>
>     stw r4, LBLAWAR1(r3) /* LBLAWAR1 <= 8MB Flash Size */
> +   /* Wait for HW to catch up */
> +   lwz r4, LBLAWAR1(r3)
> +   twi 0,r4,0
> +   isync
>     blr
>
>     /* Though all the LBIU Local Access Windows and LBC Banks will be
> @@ -1229,5 +1233,9 @@ remap_flash_by_law0:
>     xor r4, r4, r4
>     stw r4, LBLAWBAR1(r3)
>     stw r4, LBLAWAR1(r3) /* Off LBIU LAW1 */
> +   /* Wait for HW to catch up */
> +   lwz r4, LBLAWAR1(r3)
> +   twi 0,r4,0
> +   isync
>     blr
>  #endif /* CONFIG_SYS_FLASHBOOT */
> --
> 1.7.2.2
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot



More information about the U-Boot mailing list