[U-Boot] [PATCH 09/24 V2] arch/powerpc/*/config.mk:makeCONFIG_SYS_LDSCRIPT settings work

[Wolfgang Denk]

Dear Haiying Wang,

In message <1290708988.2007.13.camel at haiying-laptop> you wrote:
>
> > > u-boot-nand.lds is not in board/$(BOARDDIR) for 85xx at least, it is
> > in
> > > $(SRCTREE)/$(CPUDIR)/
> > 
> > This is not correct - situation before applying my patches:
> 
> > -> find * -name u-boot-nand.lds
> > arch/powerpc/cpu/mpc85xx/u-boot-nand.lds

Oops, sorry. I missed that one, even though I was looking for it :-(

> so your patch for arch/powerpc/config.mk will not get u-boot-nand.lds
> for mpc85xx boards, only for the boards below. Then 85xx boards still
> need to get the lds from board/$(BOARDIR)/config.mk. Is that what you
> want?

No, not really.  But actually I was just cleaning up probems where ran
into them, not trying to perform a more general cleanup [*].

The situation is that the relevant 85xx boards appeare to have their
own config.mk files which explicitly set LDSCRIPT to the value they
need (which is indeed different from the default that gets set up ib
arch/powerpc/config.mk:

arch/powerpc/config.mk:  LDSCRIPT := $(SRCTREE)/$(CONFIG_BOARDDIR)/u-boot-nand.lds

board/freescale/mpc8536ds/config.mk:   LDSCRIPT := $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds
board/freescale/mpc8569mds/config.mk:  LDSCRIPT := $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds
board/freescale/p1_p2_rdb/config.mk:   LDSCRIPT := $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds

So it seems my patches do not have any impact on the building of 85xx
systems.  Or am I missing something?

> CPUDIR is defined in config.mk, I tried it for 85xx/p1 boards and it
> worked.

OK, I'll remember this for the next optimization.

[*] There is more that can be done for ontimization: actually many of
    the PPC u-boot.lds files are (except for white space, indentation
    and tiny irrelevant details) identical. I intend to use a single,
    common linker script for all these cases, which will allow to
    remove dozens of more or less identical files.

    But I want to have a stable code base first.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Go to Heaven for the climate, Hell for the company."    - Mark Twain