[U-Boot] [PATCH] ppc4xx/POST: Change ethernet test loop count to a default of 10

Wolfgang Denk wd at denx.de
Fri Nov 26 19:32:32 CET 2010


Dear Stefan Roese,

In message <1290795460-7097-1-git-send-email-sr at denx.de> you wrote:
> This patch changes the PPC4xx ethernet POST loop test count from
> currently 192 (256 - 64) to a default of 10. While doing this the max
> frame size is increased. Each loop run uses a different frame size,
> starting with a max of 1514 bytes, down to 64. The default loop
> count of 10 can be overriden using CONFIG_SYS_POST_ETH_LOOPS in the
> board config header.
> 
> The TEST_NUM loop has been removed as it was never used.
> 
> The main reason for this change is to reduce the boot time on boards
> using this POST test, like the lwmon5 board. This change reduces the
> boot time by about 600ms on the lwmon5 board.
> 
> Signed-off-by: Stefan Roese <sr at denx.de>
> Cc: Wolfgang Denk <wd at denx.de>
> ---
> Wolfgang, I changed the loop to start with the max frame size (so that
> this value is really used) and decrease the size to the min value. Testing
> on lwmon5 showed that 1514 is the biggest value for this test to pass.
> 
> Let me know if you ack this patch version and I'll queue it for
> next in my ppc4xx repository.
> 
> Thanks.
> 
>  post/cpu/ppc4xx/ether.c |   35 ++++++++++++++++++++---------------
>  1 files changed, 20 insertions(+), 15 deletions(-)

Acked-by: Wolfgang Denk <wd at denx.de>

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When a woman marries again it is because she detested her first  hus-
band.  When  a  man  marries again, it is because he adored his first
wife.                                                  -- Oscar Wilde


More information about the U-Boot mailing list