[U-Boot] [PATCH] bugfix: image header pointer change.

Baidu Boy liucai.lfn at gmail.com
Sat Nov 27 02:08:07 CET 2010


Hi,Mike:
the purpose of below code is to copy the image header to the static
variable images.legacy_hdr_os_copy, and then the images.legacy_hdr_os
points to the
image header in  the static variable images.
------
		memmove (&images->legacy_hdr_os_copy, hdr, sizeof(image_header_t));

		/* save pointer to image header */
		images->legacy_hdr_os = hdr;
------
but the original code still lets the mages->legacy_hdr_os to point to
the header of uImage which may be overwritten in the decompress
progress.
That is not what we want.

Thanks


2010/11/27 Mike Frysinger <vapier at gentoo.org>:
> On Friday, November 26, 2010 18:59:42 Baidu Boy wrote:
>> -             show_boot_progress (6);
>> +             show_boot_progress (6);
>
> this doesnt seem to actually be changing anything.  you should avoid unrelated
> syntax changes with functional changes.
> -mike
>



-- 
------
Best Regards
Leo Liu


More information about the U-Boot mailing list