[U-Boot] [PATCH V2] bugfix: image header pointer change.

Wolfgang Denk wd at denx.de
Sat Nov 27 19:46:59 CET 2010


Dear Baidu Boy,

In message <AANLkTikZPzRFhkTsLhZPdVMCmZ9a8fN8xmiABxgYvBmK at mail.gmail.com> you wrote:
> Hi,Walfgang:
> 
> 2010/11/27 Wolfgang Denk <wd at denx.de>:
> > Dear Baidu Boy,
> >
> > Comments like the "changes for V2" gor _below_ the "---" ine, not
> > above.
> >
> > And you still don't mention anything abut the problem you are fixing
> > in the commit message.
> >
> 
> we should use the new image header after we copied it from the uImage to the
> &images->legacy_hdr_os_copy. So we should make
> images->legacy_hdr_os  point to images->legacy_hdr_os_copy, not the original
> image_header_t	*hdr

Don't explain it in some mail on some mailing list - add such comments
to the commit message, please.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Conceptual integrity in turn dictates that the  design  must  proceed
from  one  mind,  or  from  a  very small number of agreeing resonant
minds.               - Frederick Brooks Jr., "The Mythical Man Month" 


More information about the U-Boot mailing list