[U-Boot] [PATCH] Fix compiler warning in fdt_support.c
Albert ARIBAUD
albert.aribaud at free.fr
Sun Nov 28 10:10:00 CET 2010
Le 21/11/2010 20:19, dirk.behme at googlemail.com a écrit :
> From: Dirk Behme<dirk.behme at googlemail.com>
>
> Fix compiler warning
>
> fdt_support.c: In function 'of_bus_default_count_cells':
> fdt_support.c:957: warning: passing argument 1 of '__swab32p' discards qualifiers from pointer target type
> fdt_support.c:965: warning: passing argument 1 of '__swab32p' discards qualifiers from pointer target type
>
> be32_to_cpup() expects an 'u32 *' while prop is 'const u32 *'.
>
> Signed-off-by: Dirk Behme<dirk.behme at googlemail.com>
>
> ---
>
> Found while building 'omap3_beagle'.
>
> common/fdt_support.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: u-boot.git/common/fdt_support.c
> ===================================================================
> --- u-boot.git.orig/common/fdt_support.c
> +++ u-boot.git/common/fdt_support.c
> @@ -954,7 +954,7 @@ static void of_bus_default_count_cells(v
> if (addrc) {
> prop = fdt_getprop(blob, parentoffset, "#address-cells", NULL);
> if (prop)
> - *addrc = be32_to_cpup(prop);
> + *addrc = be32_to_cpup((u32 *)prop);
> else
> *addrc = 2;
> }
> @@ -962,7 +962,7 @@ static void of_bus_default_count_cells(v
> if (sizec) {
> prop = fdt_getprop(blob, parentoffset, "#size-cells", NULL);
> if (prop)
> - *sizec = be32_to_cpup(prop);
> + *sizec = be32_to_cpup((u32 *)prop);
> else
> *sizec = 1;
> }
Maybe we could pull this patch in? That will raise the count of ARM
boards building clean.
Amicalement,
--
Albert.
More information about the U-Boot
mailing list