[U-Boot] [PATCH V2 1/1] net: fix some bugs in LL TEMAC driver

Wolfgang Denk wd at denx.de
Sun Nov 28 21:35:58 CET 2010


Dear Stephan Linz,

In message <1290419192-13422-2-git-send-email-linz at li-pro.net> you wrote:
>   * avoid using link variable uninitialized
>   * avoid using phy_addr variable with invalid value
>   * reorganize phy control: first looking for phy than link
>   * return with error (result value 0) if no phy/link was found
>   * fix boolean mistake in wait for link: wait as long as we got
>     phy register 1 has no link indication (BMSR != 0x24)
>   * expand the 'first run' flag handling in ll_temac_init() in
>     respect to possible error detection in xps_ll_temac_phy_ctrl()
> 
> Signed-off-by: Stephan Linz <linz at li-pro.net>
> ---
>  drivers/net/xilinx_ll_temac.c |   52 ++++++++++++++++++++++++++++++-----------
>  1 files changed, 38 insertions(+), 14 deletions(-)

Please merges these fixzes into the next submission of the LL TEMAC
driver.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A committee is a life form with six or more legs and no brain.
                              -- Lazarus Long, "Time Enough For Love"


More information about the U-Boot mailing list