[U-Boot] [PATCH 4/4] arm920t/at91/timer: replace bss variables by gd

Wolfgang Denk wd at denx.de
Tue Nov 30 09:16:28 CET 2010


Dear "=?UTF-8?B?QW5kcmVhcyBCaWXDn21hbm4=?=",

In message <4CF4AFED.1010609 at gmail.com> you wrote:
> 
> To get this bss issue fixed for v2010.12 I'd like to add another value
> to GD to hold the last hw timer value. My current usage of tbu should
> therefore go to tbl, to have a virutal 64 bit value just counting 32
> bit, is that right?

That sounds like a terrible mess to me, please do not do that. Either
we have a 64 bit counter, hen it should cound the full 64 bit range.
Or use a plain uint32_t if 32 bit are sfficient. Don't play any
tricks like misusing an "unused" part of one variable for other,
independent purposes.

I think we should provide a "uint64_t timebase" which represents a
real 64 bit counter. And if you need a separate "uint32_t timelast"
to store the previous timer value then please make this a separate
variable.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Of all possible committee reactions to any  given  agenda  item,  the
reaction  that will occur is the one which will liberate the greatest
amount of hot air.                                -- Thomas L. Martin


More information about the U-Boot mailing list