[U-Boot] [RFC PATCH] ARM: S3C64XX: add support for mini6410

[Darius Augulis]

Hi,

thank you for review. Please find my questions inline:

>> +
>> +static void dm9000_pre_init(void)
>> +{
>> +       SROM_BW_REG &= ~(0xf << 4);
>
> u-boot don't allow it.
> Please use read/write function.
> And please access the register by C structure.

it's clear about read/write. But why C structure? We have all register
definitions in header file.
What are advantages of C structure? Many boards use definitions and I
like it. Why to change?

>> +#define CONFIG_CMDLINE_EDITING
>> +#define CONFIG_BAUDRATE                        115200
>> +#define CONFIG_SYS_BAUDRATE_TABLE      { 9600, 19200, 38400, 57600, 115200 }
>> +#define CONFIG_BOOTCOMMAND             "nand read 50100000 100000 300000; bootm 50100000"
>
> If you load the uImage to 0x500fffc0 (0x50100000 - 0x40), then you can
> reduce the boot time (about 0.5 sec?).

why? please explain.

thanks,
Darius