[U-Boot] [PATCH v2 1/7] arm: Add Support for Marvell ARMADA 100 Familiy SoCs.

[Prafulla Wadaskar]

> -----Original Message-----
> From: Heiko Schocher [mailto:hs at denx.de]
> Sent: Tuesday, November 30, 2010 12:48 PM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Eric Miao; Manas Saksena; Lei Wen; Yu Tang;
> Ashish Karkare; Kiran Vedere; Prabhanjan Sarnaik
> Subject: Re: [U-Boot] [PATCH v2 1/7] arm: Add Support for Marvell ARMADA
> 100 Familiy SoCs.
> 
> Hello Prafulla,
> 
...snip...
> > diff --git a/arch/arm/cpu/arm926ejs/armada100/timer.c
> b/arch/arm/cpu/arm926ejs/armada100/timer.c
> > new file mode 100644
> > index 0000000..b9ef8af
> > --- /dev/null
> > +++ b/arch/arm/cpu/arm926ejs/armada100/timer.c
> > @@ -0,0 +1,199 @@
> > +/*
> > + * (C) Copyright 2010
> [...]
> > +#define READ_TIMER		({volatile int loop=100; \
> > +				writel(COUNT_RD_REQ, &armd1timers->cvwr); \
> > +				while (loop--); \
> > +				readl(&armd1timers->cvwr);})
> > +static ulong timestamp;
> > +static ulong lastdec;
> 
> This local vars are stored in bss, which is not valid before relocation.
> And timer_init() is called before relocation and changes this vars.
> 
> For an example how to change this issue, look here:
> http://git.denx.de/?p=u-
> boot.git;a=commit;h=5dca710a3d7703e41da0e9894f2d71f9e25bea6b

Hi Heiko
Thanks for the feedback.
The suggested change seems to be at91 specific.
Also some other ARM SoCs do not have this implementation.

Do you mean they should also fix it?
In that case, in gt_t: making timer/clock variables available for all ARM platforms makes sense.

What do you think?

Regards..
Prafulla . .