[U-Boot] [PATCH] xyzModem.c Packet buffer dynamic allocate

Wolfgang Denk wd at denx.de
Fri Oct 1 09:57:49 CEST 2010


Dear Yoshinori Sato,

In message <87sk0q1mnf.wl%ysato at users.sourceforge.jp> you wrote:
> 
> It changes reduce bss usage.

... and increases the load on the malloc arean.

> Ymodem receive buffer dinamic allocation.

As far as I can see we increase the code size, and shift a fixed sized
buffer from bss to the maloc arene.

I don't consider this an improvement, but I may be overlooking
something.

Which advantages do you see with the changed code?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If the facts don't fit the theory, change the facts.
                                                   -- Albert Einstein


More information about the U-Boot mailing list