[U-Boot] [PATCH] xyzModem.c Packet buffer dynamic allocate

[Mike Frysinger]

On Fri, Oct 1, 2010 at 11:02 AM, Yoshinori Sato wrote:
> At Fri, 01 Oct 2010 09:57:49 +0200, Wolfgang Denk wrote:
>> Yoshinori Sato wrote:
>> > It changes reduce bss usage.
>>
>> ... and increases the load on the malloc arean.
>>
>> > Ymodem receive buffer dinamic allocation.
>>
>> As far as I can see we increase the code size, and shift a fixed sized
>> buffer from bss to the maloc arene.
>>
>> I don't consider this an improvement, but I may be overlooking
>> something.
>>
>> Which advantages do you see with the changed code?
>
> My target have too small size RAM.
> I want reduced to data and bss.
>
> It is limited to one usage in a static allocation.
> But dynamic allocation can use generically.

i feel like this is a much more uncommon usage scenario and is more
harmful than good to boards, and one which isnt specific to xyzModem.
perhaps we need a general tune config which says "prefer malloc over
bss" and this creates a set of helper macros which expand either into
malloc calls or nothing (since the storage is already in bss).
-mike