[U-Boot] AT91 clock and timer cleanups

Reinhard Meyer u-boot at emk-elektronik.de
Mon Oct 4 10:52:39 CEST 2010


Dear Wolfgang Denk,
>>> Patch 1 will change the #if and introduce CONFIG_AT91SAM9_FAMILY
>>> instead.
>>>
>>> Patch 2 will fix at91/clock.c+timer.c
>> Maybe there is a misunderstanding here. I see three patches
>>
>> 1. introduce CONFIG_AT91SAM9_FAMILY to common.h
>>
>> 2. add an #ifdef CONFIG_AT91SAM9_FAMILY to global_data.h with the
>> required variables
>>
>> 3. change clock and timer.
>>
>> 2+3 combined in one patch? OK
> 
> No.  1 + 2 belong together; they deal with the same topic and should
> be applied as a single commit.

Ok, so introducing (at this point still) unreferenced variables here is OK?

> 3 is a completely different story and goes in a separate patch.
> 
>> And I bet, this must be a patch series ;)
> 
> Not necessarily. The 1+2 combo is independent from 3 (but needed as a
> prerequisite, so posting this in a series is fine as well).

Ok, I rather post it independant, if thats OK, patch series are still
more trouble ;)


Best Regards,

Reinhard



More information about the U-Boot mailing list