[U-Boot] [PATCH] Crash in env_relocate_spec() of env_mmc.c

Sergei Shtylyov sshtylyov at mvista.com
Fri Oct 8 13:04:15 CEST 2010


Hello.

On 08-10-2010 12:03, Stefano Babic wrote:

> mmc_initialize is not called at the startup if the
> relocation takes place and the environment is stored
> into a MMC card.

> Signed-off-by: Stefano Babic<sbabic at denx.de>
[...]

> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
> index 5f2dfd0..704ddcb 100644
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c
> @@ -775,6 +775,11 @@ void board_init_r (gd_t *id, ulong dest_addr)
>   	nand_init();		/* go init the NAND */
>   #endif
>
> +#ifdef CONFIG_GENERIC_MMC
> +	puts ("MMC:   ");
> +	mmc_initialize (bd);

    This wouldn't pass checkpatch.pl. Spaces before ( are not allowed.

WBR, Sergei


More information about the U-Boot mailing list