[U-Boot] [PATCHv2 2/3] OMAP3: SDRC: Introduce Numonyx DDR type

Wolfgang Denk wd at denx.de
Sun Oct 10 12:13:11 CEST 2010


Dear =?UTF-8?Q?Enric_Balletb=C3=B2_i_Serra?=,

In message <AANLkTin9UM8UC7saYB9di0UB3D04r+hZuK5Z-xXJmmSn at mail.gmail.com> you wrote:
> 
> >> @@ -136,6 +174,10 @@ enum {
> >>   #define V_ACTIMA_165 MICRON_V_ACTIMA_165
> >>   #define V_ACTIMB_165 MICRON_V_ACTIMB_165
> >>   #endif
> >> +#ifdef CONFIG_OMAP3_NUMONYX_DDR
> >> +#define V_ACTIMA_165 NUMONYX_V_ACTIMA_165
> >> +#define V_ACTIMB_165 NUMONYX_V_ACTIMB_165
> >> +#endif
> >
> > You are using exactly the same settings as for the
> > #ifdef CONFIG_OMAP3_MICRON_DDR   above. Why do you repeat the lines
> > then? Rather use a "#if defined(...) || defined(...)"
> 
> I'm not agree the timmings are not the same, here a list of differences

Oops. I misread this. Sorry for the confusion.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Anyone attempting to generate random numbers by deterministic  means
is, of course, living in a state of sin."          - John Von Neumann


More information about the U-Boot mailing list