[U-Boot] [PATCH V5 1/2] MTD/SPI: introduce table driven probing

[Reinhard Meyer]

Dear Mike Frysinger,
>> NONE of the existing functions work with expansion, so they all get the
>> unshifted, full ID buffer.
> 
> err, right.   was thinking it also shifted off the manu id byte and not just 
> the continuation bytes.
> 
> i'll tweak the patch i posted and pull in your ramtron patch.

Thanks.

> 
>> If you provide the unshifted buffer to the function, the function should
>> get the shift amount as well. Otherwise the function will again have look
>> how many 0x7e's to skip....
> 
> not really.  the probe funcs already know the layout of the idcode, so 
> starting at a constant offset of 3 is the same as starting at 1.

True. I was already contemplating the possibility of one probe function
having to deal with different amounts of shift... But this would not
work safe in either method right now.

(Assuming the unlikely case that 7e 7e 7e 55 and 7e 7e 55 have to be handled
by the same probe function...)

This would indeed favour passing the unshifted ID buffer for such functions
to find out the amount of 7f's. If you favour that, I am game with it. But I
will resubmit the ramtron part only when the new probe is in mainline and
I have rebased my tree to it.

Reinhard