[U-Boot] [PATCHv3 0/3] Add support for the IGEP v2 board.

Steve Sakoman sakoman at gmail.com
Mon Oct 11 19:29:14 CEST 2010


On Mon, Oct 11, 2010 at 10:02 AM, Enric Balletbò i Serra
<eballetbo at gmail.com> wrote:
> Hello,
>
> 2010/10/11 Steve Sakoman <steve at sakoman.com>:
>> On Mon, 2010-10-11 at 00:12 +0200, Enric Balletbo i Serra wrote:
>>> Hello,
>>>
>>> This is the version 3 of patch series to add initial support for
>>> OMAP3 IGEP v2 board.
>>>
>>> CHANGES:
>>>
>>> * since v2
>>>     - [1/3] keep lists sorted
>>>     - [2/3] fix multiline comment style
>>>     - [3/3] add entry to MAINTAINERS
>>>
>>> * since v1
>>>     - [2/3] fix parens in NUMONYX_V_ACTIMB_165 define
>>>     - [3/3] add extra space after first &ctrl_base in file igep0020.c
>>>     - [3/3] add a space after the 57600 comma in file igep0020.h
>>>     - [3/3] remove CONFIG_SYS_ARM_WITHOUT_RELOC undef
>>>
>>> $ git diff --stat origin/master
>>>  MAINTAINERS                           |    4 +
>>>  MAKEALL                               |    1 +
>>>  arch/arm/include/asm/arch-omap3/mem.h |   43 ++++++
>>>  board/isee/igep0020/Makefile          |   49 +++++++
>>>  board/isee/igep0020/config.mk         |   33 +++++
>>>  board/isee/igep0020/igep0020.c        |  128 ++++++++++++++++++
>>>  board/isee/igep0020/igep0020.h        |  156 ++++++++++++++++++++++
>>>  boards.cfg                            |    1 +
>>>  drivers/mtd/onenand/onenand_base.c    |    1 +
>>>  include/configs/igep0020.h            |  228 +++++++++++++++++++++++++++++++++
>>>  include/linux/mtd/onenand.h           |    1 +
>>>  11 files changed, 645 insertions(+), 0 deletions(-)
>>
>> I noticed that you are using the legacy mmc driver.
>
> Yes.
>
>>
>> I've submitted a patch series to add support for the generic mmc driver
>> on OMAP3 and OMAP4.
>
> Ok
>
>>
>> Once this is upstream you might want to consider sending a patch to
>> switch IGEP v2 from the legacy driver to the generic driver.
>
> I'll do.
>
> I'll fix one build warning in version 4
>
> igep0020.c: In function 'board_eth_init':
> igep0020.c:125: warning: implicit declaration of function
> 'smc911x_initialize'
>
> but first I've a question. Some people acked and tested my patches,
> when I send the version 4. I need to add these acks in my patch or are
> automatically added ?

I typically add any Acks/Testeds I've received in the next revision.
It will save Sandeep a little work if he doesn't have to manually add
them :-)

Steve


More information about the U-Boot mailing list