[U-Boot] [PATCH 2/4] MX51: Add IPU driver for video support

[Stefano Babic]

Wolfgang Denk wrote:
> Dear Stefano Babic,
> 
> In message <1286875504-9058-3-git-send-email-sbabic at denx.de> you wrote:
>> The patch is a porting of the IPU Linux driver
>> developed by Freescale to have framebuffer
>> functionalities in u-boot.
>> Most features are dropped from the original driver and
>> only LCD support is the goal of this porting.
> 
> I don't know how close this is to the original Linux driver;
> eventually you should add a more precise reference to the original
> version in the commit message here, too.

The original driver is part of the Freescale's kernel for i.MX, based on
the vanilla kernel 2.6.31. However, the code was not sent to LKML and it
is not part of the kernel mainline.
For this reason and because I dropped a lot of parts that I thought not
useful in u-boot, this porting is not so close to the original one. I
have already tried to fix all code styling issues, but it seems I missed
a lot of them and I have to check them again. And of course, I will add
the reference to the original code, too.

> 
>> --- /dev/null
>> +++ b/drivers/video/ipu.h
>> @@ -0,0 +1,316 @@
> ...
>> +typedef unsigned char bool;
>> +#define true 1
>> +#define false 0
> 
> An, no.  Can we please drop that.

Yes, this was already in my list to drop. I missed it ;-)

> 
> Incorrect multi-line comment style. Please fix globally. [or is the
> whole file a verbatim copy of the Linux file?]

No, I will fix them.

> 
> 
>> +/* @} */
>> +/* @name YUV Planar Formats */
>> +/* @{ */
> 
> Oops. What's that?

A comment in the original code that I cannot understand and I have to
drop ;-)

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================