[U-Boot] [PATCH 2/3] nand: introduce CONFIG_NAND_EARLY_INIT and nand_early_init()

Ben Gardiner bengardiner at nanometrics.ca
Tue Oct 12 19:33:43 CEST 2010


Hello Mike,

I tested this patch series with da850evm plus NAND support; I can
confirm that the #warning is issued as expected; furthermore that when
configured with environment specified by env.oob the board boots and
obtains its environment, as expected , both with '#undef
CONFIG_NAND_MAYBE_EARLY_INIT" and "#define CONFIG_NAND_EARLY_INIT"

Tested-by: Ben Gardiner <bengardiner at nanometrics.ca>

Just one little nitpick:

On Sun, Oct 10, 2010 at 6:40 AM, Mike Frysinger <vapier at gentoo.org> wrote:
[snip]
> diff --git a/drivers/mtd/nand/nand.c b/drivers/mtd/nand/nand.c
> index 4a63d5c..a8a6292 100644
> --- a/drivers/mtd/nand/nand.c
> +++ b/drivers/mtd/nand/nand.c
> @@ -77,6 +77,10 @@ static void nand_init_chip(struct mtd_info *mtd, struct nand_chip *nand,
>
>  }
>
> +#if defined(CONFIG_NAND_MAYBE_EARLY_INIT) && !defined(CONFIG_NAND_EARLY_INIT)
> +# warning "Please read CONFIG_NAND_MAYBE_EARLY_INIT in doc/feature-removal-schedule.txt"

checkpatch warns "line over 80 characters"

Best Regards,
Ben Gardiner

---
Nanometrics Inc.
http://www.nanometrics.ca


More information about the U-Boot mailing list