[U-Boot] [PATCH] drivers/net/fec_mxc.c: write mac address in init

Wolfgang Denk wd at denx.de
Tue Oct 12 21:52:27 CEST 2010


Dear John Rigby,

In message <1283976684-30754-1-git-send-email-john.rigby at linaro.org> you wrote:
> call fec_set_hwaddr in init routine to setup MAC address
> so when ethaddr is set late the change will propagate to the hw

s/late/later/ ?

> Signed-off-by: John Rigby <john.rigby at linaro.org>
> ---
>  drivers/net/fec_mxc.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> index 2d4ffed..050c0e1 100644
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> @@ -414,6 +414,8 @@ static int fec_init(struct eth_device *dev, bd_t* bd)
>  	uint32_t base;
>  	struct fec_priv *fec = (struct fec_priv *)dev->priv;
>  
> +	/* Initialize MAC address */
> +	fec_set_hwaddr(dev);
>  	/*
>  	 * reserve memory for both buffer descriptor chains at once
>  	 * Datasheet forces the startaddress of each chain is 16 byte

Please insert blank line before comment.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It became apparent that one reason why the Ice Giants were  known  as
the  Ice  Giants  was  because they were, well, giants. The other was
that they were made of ice.              -Terry Pratchett, _Sourcery_


More information about the U-Boot mailing list