[U-Boot] [PATCH v2 4/6] boot: change some arch ifdefs to feature ifdefs
Wolfgang Denk
wd at denx.de
Tue Oct 12 23:27:08 CEST 2010
Dear John Rigby,
In message <1285775292-15060-5-git-send-email-john.rigby at linaro.org> you wrote:
> The routines boot_ramdisk_high, boot_get_cmdline and boot_get_kbd
> are currently enabled by various combinations of CONFIG_M68K,
> CONFIG_POWERPC and CONFIG_SPARC.
>
> Use CONFIG_<FEATURE> defines instead.
>
> CONFIG_BOOT_RAMDISK_HIGH
> CONFIG_BOOT_GET_CMDLINE
> CONFIG_BOOT_GET_KBD
>
> Define these as appropriate in arch/include/asm/config.h files.
No. CONFIG_ means user coinfigurable options; these are not actually
configurable on a per-board base by the end user, so CONFIG_SYS_
should be used.
> Signed-off-by: John Rigby <john.rigby at linaro.org>
> ---
> arch/m68k/include/asm/config.h | 3 +++
> arch/powerpc/include/asm/config.h | 3 +++
> arch/sparc/include/asm/config.h | 1 +
> common/cmd_bootm.c | 2 +-
> common/image.c | 10 ++++++----
> include/image.h | 9 ++++++---
> 6 files changed, 20 insertions(+), 8 deletions(-)
Also, the new variables need to be documented in the README.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He's dead, Jim
-- McCoy, "The Devil in the Dark", stardate 3196.1
More information about the U-Boot
mailing list