[U-Boot] [PATCH v2 5/6] ARM: add flat device tree support

[Wolfgang Denk]

Dear John Rigby,

In message <AANLkTikYU9LtSCHLUP-6-=vd5WPWpnyVkHkZnW23zqc5 at mail.gmail.com> you wrote:
>
> >> index 4e8dfd7..d85a396 100644
> >> --- a/arch/arm/include/asm/config.h
> >> +++ b/arch/arm/include/asm/config.h
> >> @@ -25,4 +25,6 @@
> >>  /* Relocation to SDRAM works on all ARM boards */
> >>  #define CONFIG_RELOC_FIXUP_WORKS
> >>  #endif
> >> +#define CONFIG_LMB
> >> +#define CONFIG_BOOT_RAMDISK_HIGH
> >>  #endif
> >
> > These should be CONFIG_SYS_ instead.
> These are not new.  Do you want me to submit a patch changing all
> existing instances to CONFIG_SYS_*?

Not new? I must be missing something then. I cannot find any reference
to CONFIG_BOOT_RAMDISK_HIGH anywhere in the current code.

CONFIG_LMB is indeed not new, but a misnomer that should by fixed.
Also, an explanation should be added to the README. [I am aware that
this is not a fault of your patch.]

CONFIG_RELOC_FIXUP_WORKS is also a misnomer now, and undocumented :-(

> > On which systems / architectures has this been tested?


Please make sure to proovide such information, it _is_ important.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Celestial navigation is based on the premise that the  Earth  is  the
center  of  the  universe.  The  premise is wrong, but the navigation
works. An incorrect model can be a useful tool.   - Kelvin Throop III