[U-Boot] [PATCH] ppc4xx: Add CATCenter IoCon 405EP board support

Wolfgang Denk wd at denx.de
Wed Oct 13 16:46:47 CEST 2010


Dear Dirk Eibach,

In message <1286971128-12128-1-git-send-email-eibach at gdsys.de> you wrote:
> Board support for the Guntermann & Drunck IoCon.
> 
> Signed-off-by: Dirk Eibach <eibach at gdsys.de>
> ---
>  MAINTAINERS                 |    1 +
>  MAKEALL                     |    1 +
>  board/gdsys/iocon/Makefile  |   51 +++++++
>  board/gdsys/iocon/config.mk |   24 ++++
>  board/gdsys/iocon/iocon.c   |  302 +++++++++++++++++++++++++++++++++++++++++++
>  board/gdsys/iocon/osd.c     |  255 ++++++++++++++++++++++++++++++++++++
>  board/gdsys/iocon/osd.h     |   29 ++++
>  boards.cfg                  |    1 +
>  include/configs/iocon.h     |  242 ++++++++++++++++++++++++++++++++++
>  9 files changed, 906 insertions(+), 0 deletions(-)
>  create mode 100644 board/gdsys/iocon/Makefile
>  create mode 100644 board/gdsys/iocon/config.mk
>  create mode 100644 board/gdsys/iocon/iocon.c
>  create mode 100644 board/gdsys/iocon/osd.c
>  create mode 100644 board/gdsys/iocon/osd.h
>  create mode 100644 include/configs/iocon.h

It seems thius board is very similar to the "io" board; especially
board/gdsys/iocon/{io,iocon}.c and include/configs/{ip,iocon}.h share
many, many identical lines.


Please factor out such common code.  Eventually, a single board entry
with two configurations is sufficient?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Make it right before you make it faster.


More information about the U-Boot mailing list