[U-Boot] [PATCH V2] LZO: Add a LZO compression feature

Wolfgang Denk wd at denx.de
Wed Oct 13 21:17:30 CEST 2010


Dear Donggeun Kim,

In message <4CA99DDC.5050600 at samsung.com> you wrote:
> Changes from V1 to V2:
> - Add a configuration option for the LZO compression
> - Add a comment line specifying the origin of the source code

These comments must go into the com,ment section, i. e. below the
"---" line.

> In some case, LZO compression function is needed in U-Boot.
> 
> This patch supports LZO compression feature which is originated from Linux kernel.

Please give exact reference (file name, commit id).

See http://www.denx.de/wiki/U-Boot/Patches for details.

> --- /dev/null
> +++ b/lib/lzo/lzo1x_compress.c
> @@ -0,0 +1,221 @@
> +/*
> + *  LZO1X Compressor from MiniLZO
> + *
> + *  Copyright (C) 1996-2005 Markus F.X.J. Oberhumer <markus at oberhumer.com>
> + *
> + *  The full LZO package can be found at:
> + *  http://www.oberhumer.com/opensource/lzo/
> + *
> + *  Changed for kernel use by:
> + *  Nitin Gupta <nitingupta910 at gmail.com>
> + *  Richard Purdie <rpurdie at openedhand.com>
> + *
> + *  Note : This code is taken from linux kernel.
> + */

I see no user interface (i. e. there is no way to use this function
from the command line), and I see no other users (callers) of this
code.

As such, it is just dead code, which I will not add.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
On the subject of C program indentation: "In My Egotistical  Opinion,
most  people's  C  programs  should be indented six feet downward and
covered with dirt."                               - Blair P. Houghton


More information about the U-Boot mailing list