[U-Boot] [PATCH v3] ns16550: Add WATCHDOG_RESET to putc for short watchdog timeout boards

Wolfgang Denk wd at denx.de
Wed Oct 13 22:00:35 CEST 2010


Dear Stefan Roese,

In message <1286869185-24760-1-git-send-email-sr at denx.de> you wrote:
> Call watchdog_reset() upon newline. This is done here in putc
> since the environment code uses a single puts() to print the complete
> envrironment upon "printenv". So we can't put this watchdog call
> in puts().
> 
> This is needed for boards with a very short watchdog timeout, like the
> lwmon5 with a 100ms timeout. Without this patch this board resets in the
> commands with long outputs, like "printenv" or "fdt print".
> 
> Note that the image size is not increased with this patch when
> CONFIG_HW_WATCHDOG or CONFIG_WATCHDOG are not defined since the compiler
> optimizes this additional code away.
...
> +
> +	/*
> +	 * Call watchdog_reset() upon newline. This is done here in putc
> +	 * since the environment code uses a single puts() to print the complete
> +	 * envrironment upon "printenv". So we can't put this watchdog call
--------------^ s/r//

Applied after fixing the typo.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
... The prejudices people feel about each other disappear  when  then
get to know each other.
	-- Kirk, "Elaan of Troyius", stardate 4372.5


More information about the U-Boot mailing list