[U-Boot] [PATCH] Add support for HP Jornada flashrom boards

Wolfgang Denk wd at denx.de
Wed Oct 13 22:09:14 CEST 2010


Dear Kristoffer Ericson,

In message <1286968449-5553-1-git-send-email-kristoffer.ericson at gmail.com> you wrote:
> This patch adds support for the HP Jornada flashboards
> that were made in 2008. Older flashroms should work if
> memory registers are adjusted.

Sorry, still some issues.


Please, note patch revisions and chages when resubmitting; please see
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
for details.


> +int board_init(void)
> +{
> +	gd->bd->bi_arch_number = 48;

Please use MACH_TYPE_JORNADA720 instead.

...
> +#define CONFIG_SYS_HZ			3686400 /* incrementer freq */

NAK.  CONFIG_SYS_HZ must always be defined as 1000.

Please fix and resubmit.

Thanks.

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Advice is seldom welcome; and those who want it the most always like
it the least.                         -- Philip Earl of Chesterfield


More information about the U-Boot mailing list