[U-Boot] [PATCH] mtdparts: Call nand_init() during mtdparts_init().

[Wolfgang Denk]

Dear Scott Wood,

In message <20101015173533.4e1d8bcb at udp111988uds.am.freescale.net> you wrote:
>
> > This looks like a broken design to me.
> 
> What would you rather see in its place?

Good question. I have to admit that I don't know all this code and
it's embroilments too well. There is this with MTD and that without,
there is this for JFFS2 and that without. I lost track in that maze
long ago.

Eventually we should have some mtd_init() call which does this, but
then, I'm not sure if there might not be a case ot mtdparts without
MTD.

> > Assume we add this call here; would it then not also be needed in the
> > 'static' version of mtdparts_init() in "common/cmd_jffs2.c" (whatever
> > 'static' is supposed to mean) ?
> 
> Yes, it seems so.  Is there a good reason why jffs2 has its own
> implementation of this stuff?

Too many people working on differnt parts of the code, without
looking over their respective rims ?  Sorry, I never understood.
I think Stefan spent already some time to clean up parts of the mess,
but this probably needs more effort.

> yaffs_StartUp is in a similar situation.

Oh dear. It doesn't come to an end.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What is wanted is not the will to believe,  but the will to find out,
which is the exact opposite.
		        -- Bertrand Russell, "Skeptical Essays", 1928