[U-Boot] [PATCH] Add sys_proto.h for arch-armv7

Wolfgang Denk wd at denx.de
Sat Oct 16 16:54:43 CEST 2010


Dear Alexey Zaytsev,

In message <20101015233455.4049.16990.stgit at zaytsev.su> you wrote:
> Signed-off-by: Alexey Zaytsev <alexey.zaytsev at gmail.com>
> ---
> 
> Hi.
> 
> U-boot won't build for Versatile Express (ca9x4_ct_vxp)
> without this patch. I'm not sure why the syslib is made
> armv7-specific, as it looks quite generic to me, but
> I'll leave this to the original authors.
> 
> 
>  arch/arm/include/asm/arch-armv7/sys_proto.h |   31 +++++++++++++++++++++++++++
>  1 files changed, 31 insertions(+), 0 deletions(-)

NAK.  This needs better cleanup.

Instead of adding yet another header file just to fix this current
issue, this should really be cleaned up.

We aleady have such prototype declarations in

	arch/arm/include/asm/arch-omap24xx/sys_proto.h
	arch/arm/include/asm/arch-omap3/sys_proto.h
and	arch/arm/include/asm/arch-omap4/sys_proto.h

And we have implementations in

	arch/arm/cpu/armv7/syslib.c
	board/apollon/sys_info.c
and	board/ti/omap2420h4/sys_info.c


All this needs to be moved to a single, common place.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every program has at least one bug and can be shortened by  at  least
one  instruction  --  from  which,  by induction, one can deduce that
every program can be reduced to one instruction which doesn't work.


More information about the U-Boot mailing list