[U-Boot] [PATCH] Add sys_proto.h for arch-armv7

Wolfgang Denk wd at denx.de
Sun Oct 17 20:32:10 CEST 2010


Dear Alexey Zaytsev,

In message <AANLkTim6fAZCsUFanEv2OCSvmvtiygrERRv3CirrG3N9 at mail.gmail.com> you wrote:
>
> >> U-boot won't build for Versatile Express (ca9x4_ct_vxp)
> >> without this patch. I'm not sure why the syslib is made
> >> armv7-specific, as it looks quite generic to me, but
> >> I'll leave this to the original authors.
> >>
> >>
> >> arch/arm/include/asm/arch-armv7/sys_proto.h |  31 +++++++++++++++++++++++++++
> >> 1 files changed, 31 insertions(+), 0 deletions(-)
> >
> > NAK. This needs better cleanup.
>
> Well, I'm just a simple user who wants his u-boot to build, don't know
> much about programmin' ;)
>
> > Instead of adding yet another header file just to fix this current
> > issue, this should really be cleaned up.
>
> I totally agree, but could you please rise the issue with the involved
> maintainers, and fix the vexpress build in the mean time?
> Or also break the build for the omap boards?

Sometimes poor code sneaks in unnoticed. It starts spreading, until it
gets noticed.  This time you got hit, sorry for that.  But that's how
it goes.  Many of us have been in similar situations before.

We need to fix this. I will not have yet another such file added.


Dear Sandeep,

do you happen to have this on your to-do list?


For reference, here is what I complained about:
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/86504/focus=86664


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Everything should be made as simple as possible, but not simpler."
                                                    - Albert Einstein


More information about the U-Boot mailing list