[U-Boot] [PATCH 1/3] at91rm9200ek: convert to at91

Reinhard Meyer u-boot at emk-elektronik.de
Mon Oct 18 10:40:08 CEST 2010


Dear Andreas Bießmann,
> Yes it is really. The call on this place is historic and caused no errors therefore I left it there. But it should be removed. 

The same issue is in other AT91 boards as well.

>>> @@ -113,10 +112,6 @@
>>> #define CONFIG_DBGU
>>> #undef CONFIG_USART0
>>> #undef CONFIG_USART1
>> Don't #undef what has never been defined.
> 
> You know this is historic. This are the three possible interfaces for USART on this board. At least at91rm9200 known about DBGU ;) This will be addressed when merging at91rm9200/at91 and maybe avr32 usart implementation.

I know, its like that in almost all Atmel based boards. Even worse is the AT91 method,
since some AT91 can have 6 UARTs. However unlikely that they are going to be used as console,
this is awfully bad = <at91sam9260_ek.h>:

#define CONFIG_ATMEL_USART	1
#undef CONFIG_USART0
#undef CONFIG_USART1
#undef CONFIG_USART2
#define CONFIG_USART3		1	/* USART 3 is DBGU */
Notice the last define !!!

I once tried to cleanup that a bit, but it really would affect files all across AT91.

Best Regards,
Reinhard



More information about the U-Boot mailing list