[U-Boot] [PATCH] i.MX31: Fix Litekit board to use new ARM relocation support.

Magnus Lilja lilja.magnus at gmail.com
Mon Oct 18 21:50:33 CEST 2010


Hi Stefano,

On 2010-10-18 10:30, Stefano Babic wrote:
> On 10/16/2010 07:47 PM, Magnus Lilja wrote:
>> Tested on hardware. Boots Linux nicely.
>>
>> Signed-off-by: Magnus Lilja <lilja.magnus at gmail.com>
>> ---
> 
> Hi Magnus,
> 
>> @@ -31,12 +31,18 @@ DECLARE_GLOBAL_DATA_PTR;
>>  
>>  int dram_init (void)
>>  {
>> -	gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
>> -	gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
>> +	gd->ram_size = PHYS_SDRAM_1_SIZE;
> 
> Any reason to not use get_ram_size() ?

Yes, lowlevel_init.S for the litekit board doesn't support autodetection of ram size. I suppose the SDRAM controller needs to be reprogrammed with the actual ool/row settings depending on the RAM size. 

Also, I prefer making one change in each patch so this patch updates the Litekit board to use the new relocation stuff.

Regards, Magnus


More information about the U-Boot mailing list