[U-Boot] [PATCH v3 4/7] FDT: only call boot_get_fdt from generic code
Wolfgang Denk
wd at denx.de
Mon Oct 18 22:52:25 CEST 2010
Dear John Rigby,
In message <1286999857-13790-5-git-send-email-john.rigby at linaro.org> you wrote:
> All arches except nios2 and microblaze call boot_get_fdt
> from bootm_start in common/cmd_bootm.c.
>
> Having nios2 and microblaze do so as well removes code from
> their respective do_bootm_linux routines and allows removal of
> a nasty ifdef from bootm_start.
>
> In the case where boot_get_fdt returns an error bootm_start
> returns and the platform specific do_bootm_linux routines
> will never get called.
>
> Also only check argv[3] for an fdt addr if argc > 3 first.
> This is already the case for nios2.
>
> Signed-off-by: John Rigby <john.rigby at linaro.org>
> CC: Scott McNutt <smcnutt at psyent.com>
> CC: Michal Simek <monstr at monstr.eu>
> CC: Thomas Chou <thomas at wytron.com.tw>
> ---
> arch/microblaze/lib/bootm.c | 14 +++++---------
> arch/nios2/lib/bootm.c | 8 +++-----
> common/cmd_bootm.c | 2 --
> 3 files changed, 8 insertions(+), 16 deletions(-)
Applied to u-boot-arm, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There's no sense in being precise when you don't even know what
you're talking about. -- John von Neumann
More information about the U-Boot
mailing list